-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
Hi @egeland. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/ok-to-test |
/retest |
CI is failing as the stateful set is not up in 3 mins. |
That's weird, since I didn't really change anything that would affect it...
…On 13 Aug. 2017 15:47, "Dhilip" ***@***.***> wrote:
CI is failing as the stateful set is not up in 3 mins.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1721 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABONY634cXaEq7heHZRwn05zqqNCYYOOks5sXo4EgaJpZM4O1P6s>
.
|
the CI needs to be fixed for Statefulset, I don't think it's because of the changes. /test pull-charts-e2e |
The pods don't come up because storage class "anything" won't work with the beta annotation. How about leaving the storage class update to a separate PR and then do it like so: #1332 |
Marking this as stale PR, not activity from the author |
I'm hoping to get time to make the changes soon. 😅
…On 13 Sep. 2017 19:42, "Dhilip" ***@***.***> wrote:
Marking this as stale PR, not activity from the author
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1721 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABONYxNJ5zOoOkvza_c0Ev9j01PbyIWpks5sh6OYgaJpZM4O1P6s>
.
|
fddf16e
to
eb0182c
Compare
eb0182c
to
91b5e4e
Compare
/retest |
@dhilipkumars I've updated it, and looks like it's passing now 😀 |
/ok-to-test |
/lgtm |
Some non-breaking tidy-ups of the chart.