Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/etcd] tidy up #1721

Merged
merged 3 commits into from
Sep 29, 2017
Merged

[incubator/etcd] tidy up #1721

merged 3 commits into from
Sep 29, 2017

Conversation

egeland
Copy link
Collaborator

@egeland egeland commented Aug 12, 2017

Some non-breaking tidy-ups of the chart.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @egeland. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2017
@egeland egeland changed the title Incubator etcd/tidy up [incubator/etcd] tidy up Aug 12, 2017
@dhilipkumars
Copy link
Contributor

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2017
@dhilipkumars
Copy link
Contributor

/retest

@dhilipkumars
Copy link
Contributor

CI is failing as the stateful set is not up in 3 mins.

@egeland
Copy link
Collaborator Author

egeland commented Aug 13, 2017 via email

@dhilipkumars
Copy link
Contributor

the CI needs to be fixed for Statefulset, I don't think it's because of the changes.

/test pull-charts-e2e

@dhilipkumars dhilipkumars mentioned this pull request Aug 13, 2017
Closed
@unguiculus
Copy link
Member

The pods don't come up because storage class "anything" won't work with the beta annotation. How about leaving the storage class update to a separate PR and then do it like so: #1332

@dhilipkumars
Copy link
Contributor

Marking this as stale PR, not activity from the author

@egeland
Copy link
Collaborator Author

egeland commented Sep 13, 2017 via email

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 20, 2017
@egeland
Copy link
Collaborator Author

egeland commented Sep 20, 2017

/retest

@egeland
Copy link
Collaborator Author

egeland commented Sep 20, 2017

@dhilipkumars I've updated it, and looks like it's passing now 😀

@unguiculus
Copy link
Member

/ok-to-test

@unguiculus unguiculus removed the stale label Sep 28, 2017
@unguiculus
Copy link
Member

/lgtm

@unguiculus unguiculus merged commit 1c50d9b into helm:master Sep 29, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@unguiculus unguiculus

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@egeland @k8s-ci-robot @dhilipkumars @unguiculus