Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[helm/charts] [incubator/wave] Adds pusher/wave to helm incubator charts #17866

Closed
wants to merge 2 commits into from
Closed

[helm/charts] [incubator/wave] Adds pusher/wave to helm incubator charts #17866

wants to merge 2 commits into from

Conversation

marcostvz
Copy link
Contributor

Signed-off-by: Marcos Estevez marcos.stvz@gmail.com

This is a new chart under incubator.

What this PR does / why we need it:

  • wave an opensource tool maintained by pusher
  • wave is a Kubernetes controller to watch changes in ConfigMap and Secrets and then restart pods for Deployment, StatefulSet, and DaemonSet
  • Added to the incubator repository because it needs proper testing and more contributions before going to stable

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@marcostvz
[helm/charts] [incubator/wave] Adds pusher/wave to helm incubator charts
e4d7e90 
Signed-off-by: Marcos Estevez <marcos.stvz@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcostvz
To complete the pull request process, please assign prydonius
You can assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @marcostvz. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Oct 10, 2019
@marcostvz marcostvz mentioned this pull request Oct 10, 2019
Merged
@zanhsieh
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 10, 2019
@zanhsieh
Copy link
Collaborator

/verify-owners

@helm-bot helm-bot removed the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 11, 2019
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 11, 2019
@marcostvz
Adds maintainers to Chart.yaml
131d047 
Fixes labels

Signed-off-by: Marcos Estevez <marcos.stvz@gmail.com>
@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the helm org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • JoelSpeed
    • incubator/wave/OWNERS
  • marcostvz
    • incubator/wave/OWNERS

@zanhsieh
Copy link
Collaborator

@marcostvz
Do you guys mind to host your own chart? As per discussion with @maorfr :
#5071 (comment)

@stale
Copy link

stale bot commented Nov 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2019
@stale
Copy link

stale bot commented Nov 25, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Nov 25, 2019
@stale
Copy link

stale bot commented Nov 25, 2019

This issue is being automatically closed due to inactivity.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulczar paulczar Awaiting requested review from paulczar

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcostvz @k8s-ci-robot @zanhsieh @helm-bot