Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/mongodb-replicaset] Adjusting storage to non alpha/beta if using v1.7 or higher #1874

Closed
wants to merge 1 commit into from
Closed

[stable/mongodb-replicaset] Adjusting storage to non alpha/beta if using v1.7 or higher #1874

wants to merge 1 commit into from

Conversation

venezia
Copy link
Contributor

@venezia venezia commented Aug 28, 2017

Per https://kubernetes.io/docs/concepts/storage/persistent-volumes/#class-1 moving storage class setting to spec.storageClassName

Also incrementing the version to account for the change

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 28, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @venezia. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2017
@mgoodness mgoodness changed the title Adjusting storage to non alpha/beta if using v1.7 or higher [stable/mongodb-replicaset] Adjusting storage to non alpha/beta if using v1.7 or higher Sep 4, 2017
@mgoodness mgoodness self-assigned this Sep 4, 2017
mgoodness
mgoodness suggested changes Sep 4, 2017
View reviewed changes
stable/mongodb-replicaset/templates/mongodb-statefulset.yaml
{{- if .Values.persistentVolume.storageClass | quote }}
volume.beta.kubernetes.io/storage-class: {{ .Values.persistentVolume.storageClass | quote }}
{{- else }}
volume.alpha.kubernetes.io/storage-class: default
{{- end }}
{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole block can be deleted, as we don't currently support K8s < 1.6.

stable/mongodb-replicaset/templates/mongodb-statefulset.yaml
{{- else }}
storageClassName: default
{{- end }}
{{- end }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy the pattern introduced in #1332

@mgoodness
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 4, 2017
@k8s-ci-robot
Copy link
Contributor

@venezia: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-charts-e2e 94bbff7 link /test pull-charts-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mgoodness mgoodness added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 10, 2017
@unguiculus
Copy link
Member

This has been superseded by #2013.

Related issue: #1869

@unguiculus unguiculus closed this Sep 13, 2017
@venezia venezia deleted the mongodb_update_storage branch October 27, 2017 06:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgoodness mgoodness mgoodness requested changes

Assignees

@mgoodness mgoodness

Labels
changes needed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@venezia @k8s-ci-robot @mgoodness @unguiculus