-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/mongodb-replicaset] Adjusting storage to non alpha/beta if using v1.7 or higher #1874
Conversation
Hi @venezia. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
{{- if .Values.persistentVolume.storageClass | quote }} | ||
volume.beta.kubernetes.io/storage-class: {{ .Values.persistentVolume.storageClass | quote }} | ||
{{- else }} | ||
volume.alpha.kubernetes.io/storage-class: default | ||
{{- end }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This whole block can be deleted, as we don't currently support K8s < 1.6.
{{- else }} | ||
storageClassName: default | ||
{{- end }} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy the pattern introduced in #1332
/ok-to-test |
@venezia: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Per https://kubernetes.io/docs/concepts/storage/persistent-volumes/#class-1 moving storage class setting to
spec.storageClassName
Also incrementing the version to account for the change