Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/hazelcast] removed redundant serviceAccountName (#82) #19038

Merged
merged 1 commit into from
Nov 21, 2019
Merged

[stable/hazelcast] removed redundant serviceAccountName (#82) #19038

merged 1 commit into from
Nov 21, 2019

Conversation

devOpsHelm
Copy link
Contributor

No description provided.

removed redundant serviceAccountName (helm#82)
c34f2a1 
Signed-off-by: devOpsHelm <devops+1@hazelcast.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Nov 21, 2019
@devOpsHelm
Copy link
Contributor Author

Please approve @hasancelik @leszko @mesutcelik @googlielmo @eminn

@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @devOpsHelm. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 21, 2019
@leszko
Copy link
Contributor

leszko commented Nov 21, 2019

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2019
@leszko
Copy link
Contributor

leszko commented Nov 21, 2019

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devOpsHelm, leszko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 21, 2019
@leszko
Copy link
Contributor

leszko commented Nov 21, 2019

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@leszko: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 9307ea3 into helm:master Nov 21, 2019
JoseAlban pushed a commit to JoseAlban/charts that referenced this pull request Nov 22, 2019
@devOpsHelm
removed redundant serviceAccountName (helm#82) (helm#19038)
3b0f4fb 
Signed-off-by: devOpsHelm <devops+1@hazelcast.com>
crmarques pushed a commit to crmarques/charts that referenced this pull request Nov 29, 2019
@devOpsHelm
removed redundant serviceAccountName (helm#82) (helm#19038)
1b5093b 
Signed-off-by: devOpsHelm <devops+1@hazelcast.com>
Signed-off-by: Carlos Roberto Marques Junior <carlos.marques@bndes.gov.br>
hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@devOpsHelm
removed redundant serviceAccountName (helm#82) (helm#19038)
6fcb4d5 
Signed-off-by: devOpsHelm <devops+1@hazelcast.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@devOpsHelm @dargolith
removed redundant serviceAccountName (helm#82) (helm#19038)
07efd97 
Signed-off-by: devOpsHelm <devops+1@hazelcast.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devOpsHelm @k8s-ci-robot @leszko @helm-bot