Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cockroachdb] Used storageClassName for cockroachdb. #1969

Closed
wants to merge 1 commit into from
Closed

[stable/cockroachdb] Used storageClassName for cockroachdb. #1969

wants to merge 1 commit into from

Conversation

gyliu513
Copy link
Contributor

@gyliu513 gyliu513 commented Sep 4, 2017

Fixed cockroachdb for #1869

/cc @unguiculus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2017
@gyliu513
Copy link
Contributor Author

gyliu513 commented Sep 4, 2017

/test pull-charts-e2e

@prydonius
Copy link
Member

@gyliu513 this seems incomplete, can we follow the same format in your other PRs?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2017
@gyliu513
Copy link
Contributor Author

gyliu513 commented Sep 4, 2017

@prydonius done

prydonius
prydonius suggested changes Sep 4, 2017
View reviewed changes
stable/cockroachdb/templates/cockroachdb-statefulset.yaml Outdated
spec:
accessModes:
- "ReadWriteOnce"
resources:
requests:
storage: "{{ .Values.Storage }}"
{{- if .Values.StorageClass }}
{{- if (eq "-" .Values.StorageClass) }}
storageClassName: ""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is at the wrong indent level, it should be under spec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, thanks @prydonius

@prydonius
Copy link
Member

/retest

prydonius
prydonius reviewed Sep 5, 2017
View reviewed changes
stable/cockroachdb/values.yaml Outdated
## If undefined (the default) or set to null, no storageClassName spec is
## set, choosing the default provisioner. (gp2 on AWS, standard on
## GKE, AWS & OpenStack)
##
StorageClass: "anything"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be commented to:

StorageClass: "-"

to be consistent with the others

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@viglesiasce
Copy link
Contributor

/retest

1 similar comment
@viglesiasce
Copy link
Contributor

/retest

@gyliu513
Copy link
Contributor Author

/cc @unguiculus @prydonius for approve

@k8s-ci-robot
Copy link
Contributor

@gyliu513: GitHub didn't allow me to request PR reviews from the following users: for, approve.

Note that only kubernetes members can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @unguiculus @prydonius for approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 17, 2018
@unguiculus
Copy link
Member

This is now obsolete.

@unguiculus unguiculus closed this Jan 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@unguiculus unguiculus Awaiting requested review from unguiculus

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@prydonius prydonius

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gyliu513 @prydonius @viglesiasce @k8s-ci-robot @fejta-bot @unguiculus