-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/cockroachdb] Used storageClassName for cockroachdb. #1969
Conversation
/test pull-charts-e2e |
@gyliu513 this seems incomplete, can we follow the same format in your other PRs? |
66d3852
to
cba9499
Compare
@prydonius done |
spec: | ||
accessModes: | ||
- "ReadWriteOnce" | ||
resources: | ||
requests: | ||
storage: "{{ .Values.Storage }}" | ||
{{- if .Values.StorageClass }} | ||
{{- if (eq "-" .Values.StorageClass) }} | ||
storageClassName: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is at the wrong indent level, it should be under spec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, thanks @prydonius
cba9499
to
babec42
Compare
/retest |
babec42
to
5f99bfb
Compare
stable/cockroachdb/values.yaml
Outdated
## If undefined (the default) or set to null, no storageClassName spec is | ||
## set, choosing the default provisioner. (gp2 on AWS, standard on | ||
## GKE, AWS & OpenStack) | ||
## | ||
StorageClass: "anything" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be commented to:
StorageClass: "-"
to be consistent with the others
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
5f99bfb
to
bdba979
Compare
/retest |
1 similar comment
/retest |
bdba979
to
9d61cf0
Compare
/cc @unguiculus @prydonius for approve |
@gyliu513: GitHub didn't allow me to request PR reviews from the following users: for, approve. Note that only kubernetes members can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
This is now obsolete. |
Fixed cockroachdb for #1869
/cc @unguiculus