[stable/drupal] Use storageClassName for drupal. #1989
Conversation
k8s-ci-robot
added
cncf-cla: yes
| @@ -25,4 +17,13 @@ spec: | |||
| resources: | |||
| requests: | |||
| storage: {{ .Values.persistence.drupal.size | quote }} | |||
| {{- if (not .Values.persistence.drupal.hostPath) }} | |||
| {{- if .Values.persistence.drupal.storageClass }} | |||
There was a problem hiding this comment.
could be
{{- if and .Values.persistence.drupal.storageClass (not .Values.persistence.drupal.hostPath) -}}
you might need to wrap the and in parens too, be sure to test it
There was a problem hiding this comment.
Done, thanks @prydonius
|
@prydonius mariadb is here #2004 |
|
Reviewing this re |
|
@scottrigby this just make sure that we do not need |
|
@gyliu513 This looks correct, just have not yet been able to test yet. Will do this weekend. |
|
@gyliu513 I finally got to check this and ensured |
|
Thanks @scottrigby for the test, @prydonius , can we get this merged? |
| digest: sha256:e1af13ac4ac21f67582006f12d2b4eb78a1a2a59b34338fac850f2bec0b08b41 | ||
| generated: 2017-08-09T22:52:48.218901909-04:00 | ||
| version: 1.0.5 | ||
| digest: sha256:08de643d4a3b2886a76b7f5da8ea7db20b7a69b8de1d04594862adfe4735993c |
There was a problem hiding this comment.
@prydonius thanks for the update, can you please show me how does those sha256 generated/how does the timestamp generated, so that I will not forget update here next time. Thanks
There was a problem hiding this comment.
Sure, so to bump a version you need to update requirements.yaml to the version to bump to. Then you run helm dep update ./path/to/chart and this will fetch the new version, update requirements.lock and populate the sha.
| version: 0.7.0 | ||
| digest: sha256:e1af13ac4ac21f67582006f12d2b4eb78a1a2a59b34338fac850f2bec0b08b41 | ||
| generated: 2017-08-09T22:52:48.218901909-04:00 | ||
| version: 1.0.5 |
There was a problem hiding this comment.
Why did the version here is 1.0.5?
There was a problem hiding this comment.
Just grabbing the latest version of mariadb which also includes the storageClass update
There was a problem hiding this comment.
Thanks, I see, just forget to update my local code..
Fixed drupal for #1869
/cc @prydonius