-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/drupal] Use storageClassName for drupal. #1989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait for mariadb
cc @scottrigby r.e. hostmount
@@ -25,4 +17,13 @@ spec: | |||
resources: | |||
requests: | |||
storage: {{ .Values.persistence.drupal.size | quote }} | |||
{{- if (not .Values.persistence.drupal.hostPath) }} | |||
{{- if .Values.persistence.drupal.storageClass }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be
{{- if and .Values.persistence.drupal.storageClass (not .Values.persistence.drupal.hostPath) -}}
you might need to wrap the and
in parens too, be sure to test it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks @prydonius
@prydonius mariadb is here #2004 |
Reviewing this re |
@scottrigby this just make sure that we do not need |
@gyliu513 This looks correct, just have not yet been able to test yet. Will do this weekend. |
@gyliu513 I finally got to check this and ensured |
Thanks @scottrigby for the test, @prydonius , can we get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
digest: sha256:e1af13ac4ac21f67582006f12d2b4eb78a1a2a59b34338fac850f2bec0b08b41 | ||
generated: 2017-08-09T22:52:48.218901909-04:00 | ||
version: 1.0.5 | ||
digest: sha256:08de643d4a3b2886a76b7f5da8ea7db20b7a69b8de1d04594862adfe4735993c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prydonius thanks for the update, can you please show me how does those sha256 generated/how does the timestamp generated, so that I will not forget update here next time. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, so to bump a version you need to update requirements.yaml
to the version to bump to. Then you run helm dep update ./path/to/chart
and this will fetch the new version, update requirements.lock
and populate the sha.
version: 0.7.0 | ||
digest: sha256:e1af13ac4ac21f67582006f12d2b4eb78a1a2a59b34338fac850f2bec0b08b41 | ||
generated: 2017-08-09T22:52:48.218901909-04:00 | ||
version: 1.0.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did the version here is 1.0.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just grabbing the latest version of mariadb which also includes the storageClass update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I see, just forget to update my local code..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to leave an actual GitHub "review". LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good after rebase 💯
Fixed drupal for #1869
/cc @prydonius