Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/cluster-autoscaler] Adds support for affinity to the cluster autoscaler #2298

Merged
merged 3 commits into from
Oct 18, 2017
Merged

[stable/cluster-autoscaler] Adds support for affinity to the cluster autoscaler #2298

merged 3 commits into from
Oct 18, 2017

Conversation

philipbjorge
Copy link
Contributor

Adds the ability to specify affinity instead of just nodeSelector

@k8s-ci-robot
Copy link
Contributor

Hi @philipbjorge. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 20, 2017
viglesiasce
viglesiasce suggested changes Sep 30, 2017
View reviewed changes
Copy link
Contributor

@viglesiasce viglesiasce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this value to the values.yaml as well but leave it commented out.

@viglesiasce
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 30, 2017
viglesiasce
viglesiasce previously requested changes Sep 30, 2017
View reviewed changes
Copy link
Contributor

@viglesiasce viglesiasce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a version bump in the Chart.yaml

@mgoodness mgoodness self-assigned this Oct 12, 2017
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 13, 2017
@philipbjorge
Copy link
Contributor Author

@mgoodness @viglesiasce -- Took care of the feedback :)

@mgoodness mgoodness merged commit 8b63a56 into helm:master Oct 18, 2017
dnelson pushed a commit to Vungle/charts that referenced this pull request Oct 26, 2017
@philipbjorge @dnelson
[stable/cluster-autoscaler] Adds support for affinity to the cluster …
6ef65e4 
…autoscaler (helm#2298)

* Add affinity to cluster autoscaler

* Add affinity to values.yaml

* Bump cluster-autoscaler to 0.2.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viglesiasce viglesiasce viglesiasce left review comments

Assignees

@mgoodness mgoodness

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@philipbjorge @k8s-ci-robot @viglesiasce @mgoodness