-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/nginx-ingress] Add configurable serviceMonitor metricRelabelling and targetLabels #23527
Conversation
Signed-off-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: calvinbui The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @calvinbui. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @taharah |
This chart is being deprecated via #22823 |
There's still no migration path so it's not really deprecated yet according to https://github.com/helm/charts/issues/21103 |
@ChiefAlexander should I re-open this over in ingress-nginx? |
/hold I'm working on a PR to add migration steps to the chart readme for the @calvinbui Yes please open a PR over there. Thanks! |
recreated at kubernetes/ingress-nginx#6039 |
Signed-off-by: Calvin Bui 3604363+calvinbui@users.noreply.github.com
What this PR does / why we need it:
Target Labels: Adds the serviceMonitor
targetLabels
key as documented in the Prometheus Operator APIMetric Relabelings: Adds the ServiceMonitor metricRelabelings key as documented in the Prometheus Operator API. Used for adding, dropping or renaming labels at ingestion time, or to drop entire metrics that are not useful.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)