Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Filebeat k8s fix #4408

Merged
merged 3 commits into from
Mar 27, 2018
Merged

Filebeat k8s fix #4408

merged 3 commits into from
Mar 27, 2018

Conversation

sstarcher
Copy link
Collaborator

Fixes - elastic/beats#6353
And fixes logs from /var/log
Drops filebeat logs to prevent excess pressure from filebeat erroring when the output is backed up

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 22, 2018
@sstarcher
Copy link
Collaborator Author

/assign @mgoodness

@ghost
Copy link

ghost commented Mar 22, 2018

Related: #4372

@rifelpet
Copy link
Contributor

rifelpet commented Mar 22, 2018

@sstarcher between this and #4372 which PR do you think would make more sense to merge first and have the other rebase?

@sstarcher
Copy link
Collaborator Author

@rifelpet you took a different tact than I did. I removed the prospector directory and moved it into the primary configuration.

I think the main thing of importance is it useful to separate the prospector configuration or to just merge it into the primary configuration?

If we should keep the prospector we should merge yours first and I should redo mine.
If we should merge the prospector into the main config we should merge mine and redo yours.

Opinions?

@rifelpet
Copy link
Contributor

@sstarcher I am by no means a Filebeat expert but I think consolidating the configurations into one kubernetes resource probably makes the most sense 👍

@sstarcher
Copy link
Collaborator Author

@rifelpet sounds good if that's the case sounds like we should get this one merged in first.

@sstarcher
Copy link
Collaborator Author

/assign @rifelpet

@rifelpet
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2018
@rifelpet
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2018
@rifelpet
Copy link
Contributor

/assign @mgoodness

@unguiculus
Copy link
Member

/ok-to-test

@unguiculus
Copy link
Member

/assign

@timstoop
Copy link
Contributor

/lgtm

@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, sstarcher, timstoop, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2018
@k8s-ci-robot k8s-ci-robot merged commit fa18254 into helm:master Mar 27, 2018
rolanddb pushed a commit to Eneco/charts that referenced this pull request Apr 9, 2018
* upgrade filebeat to 6.2.3 to prevent k8s metadata infinite loop

* fix filebeat /var/log and drop seperate prospectors configuration

* fix linting
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
* upgrade filebeat to 6.2.3 to prevent k8s metadata infinite loop

* fix filebeat /var/log and drop seperate prospectors configuration

* fix linting
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
* upgrade filebeat to 6.2.3 to prevent k8s metadata infinite loop

* fix filebeat /var/log and drop seperate prospectors configuration

* fix linting

Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants