-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Guidelines: set matchLabels as being mandatory #7692
Conversation
cc @scottrigby |
I've pushed one more commit introducing an upgrade path for selector. I am not sure it is the right place to write it, so feel free to discuss. |
Could you also update the persistence section in the guidelines to include |
Not sure about PVC. Looks like labels work differently there. I suggested to add |
I think matchLabels for PVC are related to their PV counterpart, which (hopefully) is out of scope. I'd be glad to see confirmation. I've followed your change requests and created a few discussions. |
/do-not-merge |
@desaintmartin @unguiculus @cpanato Can we remove the hold. This LGTM. |
/hold cancel |
Should we merge? @unguiculus any remark about |
/ok-to-test |
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
…peat component part. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
I think we can merge this. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desaintmartin, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Guidelines: set matchLabels as being mandatory. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * fixup! Guidelines: set matchLabels as being mandatory. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * fixup! fixup! Guidelines: set matchLabels as being mandatory. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Update guidelines: mention DaemonSets as well. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Review guidelines: be more precise + specify upgrade Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Review guidelines: fix typos, add persistence paragraph and do not repeat component part. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Review guidelines: add PVC paragraph. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Fix spelling/typos Signed-off-by: Reinhard Nägele <unguiculus@gmail.com> * Fix incorrect typo fix Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
* Guidelines: set matchLabels as being mandatory. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * fixup! Guidelines: set matchLabels as being mandatory. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * fixup! fixup! Guidelines: set matchLabels as being mandatory. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Update guidelines: mention DaemonSets as well. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Review guidelines: be more precise + specify upgrade Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Review guidelines: fix typos, add persistence paragraph and do not repeat component part. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Review guidelines: add PVC paragraph. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Fix spelling/typos Signed-off-by: Reinhard Nägele <unguiculus@gmail.com> * Fix incorrect typo fix Signed-off-by: Reinhard Nägele <unguiculus@gmail.com> Signed-off-by: Jakob Niggel <info@jakobniggel.de>
* Guidelines: set matchLabels as being mandatory. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * fixup! Guidelines: set matchLabels as being mandatory. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * fixup! fixup! Guidelines: set matchLabels as being mandatory. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Update guidelines: mention DaemonSets as well. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Review guidelines: be more precise + specify upgrade Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Review guidelines: fix typos, add persistence paragraph and do not repeat component part. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Review guidelines: add PVC paragraph. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * Fix spelling/typos Signed-off-by: Reinhard Nägele <unguiculus@gmail.com> * Fix incorrect typo fix Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Also move "multiple components" hint and separate the 3 different topics.
See https://github.com/helm/charts/issues/3011 and #7680