Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/ipfs] Add profile configurable parameter #7746

Closed
wants to merge 2 commits into from

Conversation

akaihola
Copy link

@akaihola akaihola commented Sep 15, 2018

What this PR does / why we need it:
The new profile parameter can be used to choose which IPFS profile to apply when creating a new IPFS configuration. In hosted server environments, it's important to use ifps init --profile=server (see e.g. ipfs/kubo#4343 and ipfs/kubo#5511).

Special notes for your reviewer:
@yuvipanda, this change requires ipfs/kubo#5473 to be merged and included in a released go-ipfs Docker image.

Update: ipfs/kubo#5473 has been merged.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akaihola
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: prydonius

If they are not already assigned, you can assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @akaihola. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 15, 2018
The `profile` parameter can be used to choose which IPFS profile to
apply when creating a new IPFS configuration.

Signed-off-by: Antti Kaihola <antti+ipfs@kaihola.fi>
@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 23, 2018
Signed-off-by: Antti Kaihola <antti+ipfs@kaihola.fi>
@stale
Copy link

stale bot commented Oct 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2018
@akaihola
Copy link
Author

@yuvipanda, the pull request ipfs/kubo#5473 which is required by this one seems to be approved by reviewers but not yet merged.

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 23, 2018
@akaihola
Copy link
Author

/assign @prydonius
/assign @yuvipanda

@k8s-ci-robot
Copy link
Contributor

@akaihola: GitHub didn't allow me to assign the following users: yuvipanda.

Note that only helm members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @prydonius
/assign @yuvipanda

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale
Copy link

stale bot commented Nov 22, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 22, 2018
@akaihola
Copy link
Author

@prydonius and @yuvipanda, anything I could do to have this patch considered for merging? Note that ipfs/kubo#5473 has now been merged so that's not a blocker for merging this one anymore.

What this PR does / why we need it:
The new profile parameter can be used to choose which IPFS profile to apply when creating a new IPFS configuration. In hosted server environments, it's important to use ifps init --profile=server (see e.g. ipfs/kubo#4343 and ipfs/kubo#5511).

Special notes for your reviewer:
@yuvipanda, this change requires ipfs/kubo#5473 to be merged and included in a released go-ipfs Docker image.

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 28, 2018
@yuvipanda
Copy link
Contributor

@akaihola unfortunately, I haven't really done much with IPFS in the last year or so, and don't have the bandwidth to maintain the chart here :( I'm not exactly sure what to do wrt maintainership now.

@akaihola
Copy link
Author

@davidkarlsen, could you help with getting this patch reviewed?

@yuvipanda is no longer working with IPFS, and I couldn't get a reply from @prydonius (one of the help/charts owners).

@stale
Copy link

stale bot commented Jan 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 28, 2019
@akaihola
Copy link
Author

@cpanato, could you help with getting this patch reviewed?

@yuvipanda is no longer working with IPFS, and I couldn't get a reply from @prydonius or @davidkarlsen (other helm/charts owners).

@stale
Copy link

stale bot commented Feb 12, 2019

This issue is being automatically closed due to inactivity.

@stale stale bot closed this Feb 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants