-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/ipfs] Add profile
configurable parameter
#7746
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: akaihola If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @akaihola. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The `profile` parameter can be used to choose which IPFS profile to apply when creating a new IPFS configuration. Signed-off-by: Antti Kaihola <antti+ipfs@kaihola.fi>
baf8b65
to
21addee
Compare
Signed-off-by: Antti Kaihola <antti+ipfs@kaihola.fi>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
@yuvipanda, the pull request ipfs/kubo#5473 which is required by this one seems to be approved by reviewers but not yet merged. |
/assign @prydonius |
@akaihola: GitHub didn't allow me to assign the following users: yuvipanda. Note that only helm members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
@prydonius and @yuvipanda, anything I could do to have this patch considered for merging? Note that ipfs/kubo#5473 has now been merged so that's not a blocker for merging this one anymore.
|
@akaihola unfortunately, I haven't really done much with IPFS in the last year or so, and don't have the bandwidth to maintain the chart here :( I'm not exactly sure what to do wrt maintainership now. |
@davidkarlsen, could you help with getting this patch reviewed? @yuvipanda is no longer working with IPFS, and I couldn't get a reply from @prydonius (one of the help/charts owners). |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
@cpanato, could you help with getting this patch reviewed? @yuvipanda is no longer working with IPFS, and I couldn't get a reply from @prydonius or @davidkarlsen (other helm/charts owners). |
This issue is being automatically closed due to inactivity. |
What this PR does / why we need it:
The new
profile
parameter can be used to choose which IPFS profile to apply when creating a new IPFS configuration. In hosted server environments, it's important to useifps init --profile=server
(see e.g. ipfs/kubo#4343 and ipfs/kubo#5511).Special notes for your reviewer:
@yuvipanda, this change requires ipfs/kubo#5473 to be merged and included in a released go-ipfs Docker image.
Update: ipfs/kubo#5473 has been merged.