This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/opencart] Fix chart not being upgradable #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
needs-ok-to-test
ey-bot
added
Contribution Allowed
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
@javsalgar could you sign your commits? Please check the instructions you can find under "Details" section DCO bot response |
ey-bot
added
the
Contribution Allowed
Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
ey-bot
added
the
Contribution Allowed
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: javsalgar, juan131 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
2 tasks
jicowan
pushed a commit
to jicowan/charts
that referenced
this pull request
Oct 2, 2018
* [stable/opencart] Fix chart not being upgradable Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> * Update chart and readme Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> Signed-off-by: jenkin-x <jicowan@hotmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
* [stable/opencart] Fix chart not being upgradable Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> * Update chart and readme Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* [stable/opencart] Fix chart not being upgradable Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> * Update chart and readme Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add spec.selector.matchLabels without the
chartlabel.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #5657Chart was not being upgradable
Special notes for your reviewer: