This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[stable/postgresql] PostgreSQL maintenance proposal #8004
[stable/postgresql] PostgreSQL maintenance proposal #8004
Changes from 15 commits
c0ae3a1
18c2ebd
2f5424f
78ba678
b031c71
72a1110
1ca7948
119a35a
223a7e0
59cf3c2
8f39fa4
2b91278
f5f6659
2bcb6f4
a385ce2
24aa787
e69f213
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you intend to keep support somehow of pg_hba.conf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! At this moment the chart supports custom configuration using
postgresql.conf
, but I am working to provide support for both (postgresql.conf
andpg_hba.conf
). But this change not only requires modifications in the chart (this is the easy part), it also requires changes in the Docker image.TL;DR I am working to modify the Docker image to support it.
Do you think it is a blocking issue to merge it or can we merge the PR and send a new one with the
ph_hba.conf
changes after some days?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is blocking for me (I have a dozen of postgres running using that feature) for the long term but I guess it can wait for a few days with no harm and in case of problem I can use my own fork.
Tell me if I can help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I just added some logic to support it at chart level 92498ba, feel free to review it!
In the other hand I continue working on the Docker image stuff