Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP for custom resource ordering #230

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NiklasWagner
Copy link

This HIP will cover the option to customize the install order of custom resources.

helm/helm#9534

@NiklasWagner NiklasWagner force-pushed the hip-custom-resource-ordering branch 2 times, most recently from b624e1f to f3c2327 Compare January 11, 2022 07:38
Signed-off-by: Niklas Wagner <niklas@wagner.gg>
@tfussell
Copy link

Hi, I just found your HIP and I think it could help solve a problem I'm having during the creation of a helm release in which creation order matters. In my case all of the resources in the chart are custom resources though. Does this proposal handle ordering of CRs as well (for example creating a cert-manager Issuer CR before a Certificate that uses the issuer)?

@Skaronator
Copy link

Hi @tfussell, the HIP currently doesn't cover sorting of CR against other CR. It only supports sorting against the currently hardcoded list in Helm: https://github.com/helm/helm/blob/1ec0aacb8865d5b1f7ef1cb884bbf9b12579ecef/pkg/releaseutil/kind_sorter.go#L31-L66

@tfussell
Copy link

tfussell commented Feb 1, 2022

Thanks @Skaronator. Would you be willing to consider it if I take on the work of adding it to your HIP and proof-of-concept PR?

@Skaronator
Copy link

Sure, go ahead :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants