Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade kubectl #11

Merged
merged 3 commits into from
Dec 22, 2019
Merged

Conversation

davidkarlsen
Copy link
Member

@davidkarlsen davidkarlsen commented Dec 20, 2019

Signed-off-by: David J. M. Karlsen david@davidkarlsen.com


This change is Reviewable

Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
kind.sh Outdated Show resolved Hide resolved
kind.sh Outdated Show resolved Hide resolved
Co-Authored-By: Reinhard Nägele <unguiculus@gmail.com>
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm tempted to make kubectl version configurable, but in the spirit of fast releasing we may as well wait till we have a use case (it will be easy enough to add later). lgtm 👍

@davidkarlsen
Copy link
Member Author

Ideally the version would follow the k8s version (e.g. kind node-image tag).

@unguiculus unguiculus changed the title upgrade kubectl Upgrade kubectl Dec 22, 2019
@unguiculus unguiculus merged commit 98cb04e into helm:master Dec 22, 2019
@davidkarlsen davidkarlsen deleted the feature/upgradeKubectl branch December 22, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants