Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions trigger syntax cleanup #14

Merged
merged 2 commits into from
Mar 21, 2020

Conversation

scottrigby
Copy link
Member

Not sure if we really need to test on releases, but may be a good idea? If so, this fixes the syntax per https://help.github.com/en/actions/automating-your-workflow-with-github-actions/events-that-trigger-workflows#release-event-release. If we don't want this, we can just remove the - releases/* branch pattern matching.

Signed-off-by: Scott Rigby <scott@r6by.com>
@unguiculus
Copy link
Member

So, this tests releases as opposed to release branches. I don't see why we would want this.

@davidkarlsen
Copy link
Member

Should we just keep this as-is and close this PR? @unguiculus @scottrigby ?

@scottrigby
Copy link
Member Author

Oh hey guys I missed these comments. The thing is we don't make release branches

  1. Either way we should remove releases/* since we're not making release branches (it does nothing)
  2. testing releases isn't critical, but it would ensure specific releases pass tests

@unguiculus
Copy link
Member

The releases/* was added in #13. Don't know why. I'd just remove the releases stuff completely.

Signed-off-by: Scott Rigby <scott@r6by.com>
@scottrigby
Copy link
Member Author

OK sounds good testing master should be enough for now anyway. We won't cut a release until it succeeds.

@scottrigby scottrigby changed the title Fix actions trigger syntax for testing releases Actions trigger syntax cleanup Mar 21, 2020
@unguiculus unguiculus merged commit 702450f into helm:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants