Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kind.sh to allow arm runners #55

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Update kind.sh to allow arm runners #55

merged 1 commit into from
Apr 13, 2022

Conversation

JorTurFer
Copy link
Contributor

@JorTurFer JorTurFer commented Mar 6, 2022 •
edited
Loading

As I explained in the issue, right now this action doesn't support arm archs, with this PR, ARM64 arch will be supported too

@JorTurFer
Update kind.sh to allow multi arch
f3211d0 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer mentioned this pull request Mar 7, 2022
Merged
5 tasks
@cpanato cpanato closed this Apr 13, 2022
@cpanato cpanato reopened this Apr 13, 2022
@JorTurFer
Copy link
Contributor Author

Hi @cpanato
Any news about this?

@cpanato
Copy link
Member

cpanato commented Apr 13, 2022

Hi @cpanato Any news about this?

i just saw this today, and triggered the ci to check it, I will review soon

@JorTurFer
Copy link
Contributor Author

ah, nice!
It was confusing because I saw the PR closed and the opened. No rush at all 😄
Just for giving a working sample, we are using my fork for our arm smoke test

@cpanato
Copy link
Member

cpanato commented Apr 13, 2022

ah, nice! It was confusing because I saw the PR closed and the opened. No rush at all 😄 Just for giving a working sample, we are using my fork for our arm smoke test

was opened and close to trigger the CI that looks like was stuck

cpanato
cpanato approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cpanato cpanato merged commit 4c79091 into helm:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorTurFer @cpanato