-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop setting Cross-Origin-Embedder-Policy by default in next major version #411
Comments
This is done in the v7 branch. See #412. |
Merged in 61357a5. |
@EvanHahn Curious what kind of problem it has caused, if you are available to elaborate in a few sentences |
Good question. Many users (especially those on Stack Overflow) had a lot of trouble with this header because of the way they were loading cross-origin resources. Helmet is supposed to be easy-to-use and this was causing a lot of trouble for a lot of people, which is why I changed the default. |
@EvanHahn understood, thank you |
@stfsy It's great you've brought this up. I've had my fair share of issues with COEP, specifically having Helmet 5 & 6 setting the The following solved the issue relatively painlessly:
Helmet 7 comes with COEP disabled out of the box. |
@EvanHahn could you elaborate how to disable the COEP for .html files. I couldn't find resources to assist me in this. I referred and got to know about the issue from here https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cross-Origin-Embedder-Policy It's showing as default in VScode |
@PulastTiwari Could you please open a new issue to discuss this? Please include your Helmet configuration, too—it will make it easier to answer your question. |
This has caused lots of problems for people.
The middleware should still be there, but it should be disabled by default.
The text was updated successfully, but these errors were encountered: