267: Add http json functionality #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfgrant01
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
paulfgrant01
force-pushed
the
feature/httpjson#267
branch
3 times, most recently
from
469266f to
60e0d66
Compare
Signed-off-by: Paul Grant <paulfgrant01@gmail.com>
paulfgrant01
force-pushed
the
feature/httpjson#267
branch
from
60e0d66 to
d772c10
Compare
|
@paulfgrant01 please fix lint issue. |
…ck json server to run testing against Signed-off-by: Paul Grant <pgrant@williamhill.us>
paulfgrant01
force-pushed
the
feature/httpjson#267
branch
from
471abeb to
bbfdac5
Compare
yxxhero
reviewed
Mar 27, 2024
pkg/providers/httpjson/httpjson.go
Outdated
| "strconv" | ||
| "strings" | ||
|
|
||
| // nolint |
There was a problem hiding this comment.
Removed in favor of:
gci write -s standard -s default -s "prefix(github.com/helmfile/vals)" pkg/providers/httpjson/httpjson.go
yxxhero
reviewed
Mar 27, 2024
vals.go
Outdated
| @@ -367,6 +372,7 @@ func (r *Runtime) prepare() (*expansion.ExpandRegexMatch, error) { | |||
| } | |||
|
|
|||
| return str, nil | |||
|
|
|||
There was a problem hiding this comment.
Removed this line 👍
Signed-off-by: Paul Grant <paulfgrant01@gmail.com>
paulfgrant01
force-pushed
the
feature/httpjson#267
branch
from
70c1ff8 to
3c00eb7
Compare
yxxhero
reviewed
Mar 27, 2024
pkg/providers/httpjson/httpjson.go
Outdated
| return p | ||
| } | ||
|
|
||
| func GetXpathFromUri(uri string) (xpath string, err error) { |
There was a problem hiding this comment.
what will happen if uri is empty? and add unittest for function as possible as you can. thanks so much.
There was a problem hiding this comment.
Added unit testing 🙏
… various fixes Signed-off-by: Paul Grant <paulfgrant01@gmail.com>
… various fixes Signed-off-by: Paul Grant <paulfgrant01@gmail.com>
yxxhero
reviewed
Apr 3, 2024
Signed-off-by: Paul Grant <paulfgrant01@gmail.com>
Signed-off-by: Paul Grant <paulfgrant01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on Issue 267
This provider will retrieve a single key from a JSON structure hosted by an HTTP frontend. The signature will require both the domain and the xpath e.g.
ref+httpjson://<DOMAIN>/<PATH>?[insecure=false&floatAsInt=false]#/<XPATH>