chore: Revert "Merge pull request #513 from carnei-ro/feat/bitwarden-secrets… #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaque44
requested review from
mumoshu,
itscaro,
yxxhero and
xiaomudk
as code owners
zhaque44
force-pushed
the
rm-bitwarden-secrets
branch
from
e78b634 to
703242f
Compare
|
I said here that the Bitwarden Secrets would need CGO enabled and musl-gcc #427 (comment) |
We didn’t want any of the third party stuff you bought in like musl-gcc or anything like that. We will be enhancing our CI, and then trying to add that bitwarden after that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved: #514
reverting adding the bitwarden secrets provider, our plan is to enhance our CI pipeline with more robust testing and then add it the provider back with minimal changes not with musl-gcc <-