-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #1085: Convolve with distributed kernel on multiple GPUs #1095
Conversation
Hi @shahpratham , more changes are necessary. Bcast uses the buffer for input and output. |
I need the bug fix now. So, I'm going to fix the PR. |
Codecov Report
@@ Coverage Diff @@
## main #1095 +/- ##
=======================================
Coverage 91.80% 91.80%
=======================================
Files 72 72
Lines 10519 10520 +1
=======================================
+ Hits 9657 9658 +1
Misses 862 862
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks @mtar. Generally speaking, if you've identified problem and solution, feel free to submit a fix right away. I'll go back to PR reviews on March 3rd. |
Description
Issue resolved: #1085
Convolve is not working with multiple gpus with distributed kernel.
Changes proposed:
Type of change
Due Diligence
Does this change modify the behaviour of other functions? If so, which?
no