Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): providers with useExisting will be kept if their value is a kept declaration #3778 #3794

Merged
merged 1 commit into from
Oct 9, 2022

Conversation

satanTime
Copy link
Member

@satanTime satanTime commented Oct 9, 2022

closes #3778

@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4ef2885) compared to base (8e5c8b0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3794   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          220       221    +1     
  Lines         4555      4565   +10     
  Branches      1043      1044    +1     
=========================================
+ Hits          4555      4565   +10     
Impacted Files Coverage Δ
...ocks/src/lib/mock-builder/promise/init-universe.ts 100.00% <ø> (ø)
...g-mocks/src/lib/common/func.extract-forward-ref.ts 100.00% <100.00%> (ø)
...mocks/src/lib/mock-builder/mock-builder.promise.ts 100.00% <100.00%> (ø)
...-mocks/src/lib/mock-builder/promise/extract-dep.ts 100.00% <100.00%> (ø)
...ks/src/lib/mock-service/helper.resolve-provider.ts 100.00% <100.00%> (ø)
libs/ng-mocks/src/lib/mock/clone-providers.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satanTime satanTime changed the title fix(core): providers with useExisting will be kept if their value is a kept declaration #3791 fix(core): providers with useExisting will be kept if their value is a kept declaration #3778 Oct 9, 2022
@satanTime satanTime force-pushed the issues/3791 branch 2 times, most recently from ac39cf8 to b25433c Compare October 9, 2022 07:36
@satanTime satanTime merged commit 1832d56 into help-me-mom:master Oct 9, 2022
@satanTime satanTime deleted the issues/3791 branch October 9, 2022 08:10
@satanTime
Copy link
Member Author

v14.2.4 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Standalone CVA component
1 participant