Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): hidden usage of MockBuilder in TestBed if kept and mock modules are used together #4344 #4418

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

satanTime
Copy link
Member

closes #4344

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d77b6f2) compared to base (e7400c5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4418   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          223       223           
  Lines         4643      4677   +34     
  Branches      1057      1068   +11     
=========================================
+ Hits          4643      4677   +34     
Impacted Files Coverage Δ
.../lib/mock-builder/performance/required-metadata.ts 100.00% <ø> (ø)
libs/ng-mocks/src/lib/common/func.extract-deps.ts 100.00% <100.00%> (ø)
libs/ng-mocks/src/lib/common/func.get-type.ts 100.00% <100.00%> (ø)
...-mocks/src/lib/common/ng-mocks-global-overrides.ts 100.00% <100.00%> (ø)
...mocks/src/lib/mock-builder/mock-builder.promise.ts 100.00% <100.00%> (ø)
...ib/mock-builder/promise/add-requested-providers.ts 100.00% <100.00%> (ø)
...lib/mock-builder/promise/apply-platform-modules.ts 100.00% <100.00%> (ø)
...mocks/src/lib/mock-builder/promise/init-modules.ts 100.00% <100.00%> (ø)
...ks/src/lib/mock-builder/promise/init-ng-modules.ts 100.00% <100.00%> (ø)
...cks/src/lib/mock-builder/promise/parse-provider.ts 100.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satanTime satanTime merged commit 7dfd1b7 into help-me-mom:master Dec 11, 2022
@satanTime satanTime deleted the issues/4344 branch December 11, 2022 15:50
@satanTime
Copy link
Member Author

v14.5.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Can't export pipe MockOfAsyncPipe from MockOfPipeModule as it was neither declared nor imported!
1 participant