Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): ViewContainerRef.createComponent respects mocks #4742 #4743

Merged
merged 1 commit into from
Jan 21, 2023

Conversation

satanTime
Copy link
Member

closes #4742
closes #4693

@codecov
Copy link

codecov bot commented Jan 21, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (bd93b7b) compared to base (2abd719).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #4743   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          223       223           
  Lines         4690      4705   +15     
  Branches      1076      1078    +2     
=========================================
+ Hits          4690      4705   +15     
Impacted Files Coverage Δ
...-mocks/src/lib/common/ng-mocks-global-overrides.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satanTime satanTime merged commit 91c24e7 into help-me-mom:master Jan 21, 2023
@satanTime satanTime deleted the issues/4693 branch January 21, 2023 12:30
@satanTime
Copy link
Member Author

v14.6.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to mock a dynamically imported standalone component inside a standalone component
1 participant