Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a16): supporting required inputs #5350 #5366

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

satanTime
Copy link
Member

@satanTime satanTime commented Apr 1, 2023

closes #5350

@satanTime satanTime requested review from ike18t and getsaf as code owners April 1, 2023 14:55
@codecov
Copy link

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (23cc0a9) 100.00% compared to head (1303680) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #5366   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          224       226    +2     
  Lines         4794      4831   +37     
  Branches      1102      1113   +11     
=========================================
+ Hits          4794      4831   +37     
Impacted Files Coverage Δ
libs/ng-mocks/src/lib/common/core.config.ts 100.00% <ø> (ø)
...ib/mock-builder/promise/handle-entry-components.ts 100.00% <ø> (ø)
libs/ng-mocks/src/lib/mock/decorate-declaration.ts 100.00% <ø> (ø)
libs/ng-mocks/src/lib/common/decorate.inputs.ts 100.00% <100.00%> (ø)
libs/ng-mocks/src/lib/common/decorate.outputs.ts 100.00% <100.00%> (ø)
...ng-mocks/src/lib/common/func.directive-io-build.ts 100.00% <100.00%> (ø)
...ng-mocks/src/lib/common/func.directive-io-parse.ts 100.00% <100.00%> (ø)
libs/ng-mocks/src/lib/common/mock.ts 100.00% <100.00%> (ø)
.../lib/mock-helper/crawl/crawl-by-attribute-value.ts 100.00% <100.00%> (ø)
...ib/mock-helper/crawl/detect-selectors-from-node.ts 100.00% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satanTime satanTime force-pushed the issues/5350 branch 4 times, most recently from 80a4ec7 to f956242 Compare April 15, 2023 12:14
@satanTime satanTime merged commit 8dbcdf9 into help-me-mom:master Apr 15, 2023
@satanTime satanTime deleted the issues/5350 branch April 15, 2023 13:33
@satanTime
Copy link
Member Author

v14.9.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant