Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): merge of kept / mock declarations in CommonModule #5465 #5521

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

satanTime
Copy link
Member

closes #5465

@satanTime satanTime requested review from ike18t and getsaf as code owners April 22, 2023 11:14
@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7e90dd1) 100.00% compared to head (2dd66cd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #5521   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          226       226           
  Lines         4831      4831           
  Branches      1113      1113           
=========================================
  Hits          4831      4831           
Impacted Files Coverage Δ
libs/ng-mocks/src/lib/common/core.helpers.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satanTime satanTime force-pushed the issues/5465 branch 4 times, most recently from 4484e4f to 5ea9119 Compare April 23, 2023 07:34
@satanTime satanTime merged commit a9c0f32 into help-me-mom:master Apr 23, 2023
@satanTime satanTime deleted the issues/5465 branch April 23, 2023 07:53
@satanTime
Copy link
Member Author

v14.10.0 has been released and contains a fix for the issue. Feel free to reopen the issue or to submit a new one if you meet any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: MockModule, NgFor and @happy-dom/jest-environment
1 participant