-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MockBuilder #91
Conversation
4b21087
to
ed8da78
Compare
Hi @getsaf, I'm sorry, but can't find your comment neither here nor in the original issue, could you give me its link? Sorry about the notifications, I use the amend option and seems it produces too much noise. |
Hi @getsaf, please check the new approach without promises: https://github.com/satanTime/ng-mocks/blob/issues/44/README.md#mockbuilder. |
The idea with |
a4e9457
to
7c808ec
Compare
This PR is rather massive and rather extensive. Due to its weight and broad scope I think having this remain on a beta branch with beta release may be the safest approach. I've been keeping the lib version number in sync with verified angular version, so keeping that trend If all goes well we can have this release when we go v10. As far as review, I definitely want @getsaf 's input since he has already done this before so he has a good amount of context when it comes to module building plus we need to make sure we don't implement anything that breaks shallow-render. I'll go ahead and create the beta branch I don't know if there is a way to redirect your PR, my guess is not, so you may have to reopen. |
Agree, I'll update to against beta branch. |
Done, now it goes to beta. Let me update the PR. I think I found a way how to avoid the breaking changes. |
Done. Now there are no breaking changes. |
a4b2514
to
4160b8e
Compare
@satanTime I merged another of your PRs into master and updated the beta branch. Was going to merge this into beta and do a beta release but there is a merge conflict. If you can fix the conflict I'll merge this and do the prerelease. |
@ike18t, sure, working on it. |
@ike18t, done. |
version 10.0.0-alpha.0 released |
A
MockBuilder
to facilitate a creation of a NgModule for the TestBed.How to use can be found in its readme: https://github.com/satanTime/ng-mocks/tree/issues/44#mockbuilder
Closes #44
Closes #60
Closes #70