-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/schema and timeout #3
Conversation
…from clause . Redis timeout placed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor thing If in query_redis question doesn't contain options then the get on line 628 will throw an exception.
I really wish there was a more efficient way to update the cache only if a change occurs rather than blindly recalculating every x seconds.
Hi @waTeim , thanks for the review. Just added a default to
|
@YaphetKG - please let me know when this is tested in heal-dev - i.e. ensuring search/indexing/etc is working as expected. |
Fix makes behavior return an empty response with the query graph evaluated from the query.
Adds timeouts to queries this is configurable as per deployment via
"REDIS_QUERY_TIMEOUT" env variable. And value is in milliseconds.
Adds get parameter for /schema endpoint so we can do force refresh through an api call. Could be useful when roger pipeline finishes building graph we can let tranql recompute the schema. And don't need to wait till the next update interval.