electrumx: fix removing conn from pool #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Set
p.pool
to return value ofslices.DeleteFunc
when removing a connection.As of go1.23,
go vet
reports this issue: https://go-review.googlesource.com/c/tools/+/554317The item is still removed from the slice, however the length of the slice is not updated. See implementation of
slices.DeleteFunc
:This has likely been causing errors with the pool, such as connections not being returned and instead being closed, as well as the size being returned wrong.
Changes
p.pool
to return value ofslices.DeleteFunc
when removing a connection.