Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake.modules (opt-in) #213

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Add flake.modules (opt-in) #213

merged 2 commits into from
Sep 12, 2024

Conversation

roberth
Copy link
Member

@roberth roberth commented Feb 16, 2024

Allow modules of any class to be published.
This removes the need for custom flake attributes, such as nixosModules, flakeModules, etc.

Copy link

dpulls bot commented May 16, 2024

🎉 All dependencies have been resolved !

@roberth roberth marked this pull request as ready for review May 16, 2024 13:27
Copy link

@cdmistman cdmistman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tested and confirmed it works for my use case! thank you!

@Atry
Copy link
Contributor

Atry commented Sep 12, 2024

Any issue preventing this PR from being merged?

@roberth roberth merged commit 6a8c72c into main Sep 12, 2024
3 checks passed
@roberth roberth deleted the modules-output branch September 12, 2024 14:45
@roberth
Copy link
Member Author

roberth commented Sep 12, 2024

Documentation at flake.parts

@srid
Copy link
Contributor

srid commented Sep 12, 2024

This would be considered deprecated right?

https://flake.parts/options/flake-parts-flakemodules

@roberth
Copy link
Member Author

roberth commented Sep 12, 2024

I believe nix flake check does not accept modules yet, so I wouldn't recommend to migrate yet, but feel free to start using modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants