Merge pull request #854 from mkroening/nightly-2023-08-15

build: upgrade Rust to nightly-2023-08-15

Dockerfile

@@ -5,7 +5,7 @@ ENV RUSTUP_HOME=/usr/local/rustup \
     CARGO_HOME=/usr/local/cargo \
     PATH=/usr/local/cargo/bin:$PATH \
     # Manually sync this with rust-toolchain.toml!
-    RUST_VERSION=nightly-2023-08-01 \
+    RUST_VERSION=nightly-2023-08-15 \
     RUST_COMPONENTS="llvm-tools rust-src" \
     RUST_TARGETS="x86_64-unknown-none"
 

rust-toolchain.toml

@@ -1,6 +1,6 @@
 [toolchain]
 # Manually sync this with Dockerfile!
-channel = "nightly-2023-08-01"
+channel = "nightly-2023-08-15"
 components = [
     "llvm-tools",
     "rust-src",

src/fd/socket/tcp.rs

@@ -66,6 +66,9 @@ impl<T> Socket<T> {
 		result
 	}
 
+	// TODO: Remove allow once fixed:
+	// https://github.com/rust-lang/rust-clippy/issues/11380
+	#[allow(clippy::needless_pass_by_ref_mut)]
 	async fn async_read(&self, buffer: &mut [u8]) -> Result<isize, i32> {
 		future::poll_fn(|cx| {
 			self.with(|socket| {

xtask/src/archive.rs

@@ -1,4 +1,5 @@
 use std::env;
+use std::fmt::Write;
 use std::path::{Path, PathBuf};
 
 use anyhow::{anyhow, Result};
@@ -45,9 +46,10 @@ impl Archive {
 		let archive = self.as_ref();
 		let prefix = archive.file_stem().unwrap().to_str().unwrap();
 
-		let symbol_renames = symbols
-			.map(|symbol| format!("{prefix}_{symbol} {symbol}\n"))
-			.collect::<String>();
+		let symbol_renames = symbols.fold(String::new(), |mut output, symbol| {
+			let _ = writeln!(output, "{prefix}_{symbol} {symbol}");
+			output
+		});
 
 		let rename_path = archive.with_extension("redefine-syms");
 		sh.write_file(&rename_path, symbol_renames)?;