Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Cargo.lock #276

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Remove Cargo.lock #276

merged 1 commit into from
Oct 29, 2021

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Sep 5, 2021 •
edited
Loading

Since we use no Cargo.lock in downstream builds, we should not use one in upstream CI either.

@mkroening mkroening requested a review from stlankes September 5, 2021 08:44
@stlankes
Copy link
Contributor

stlankes commented Sep 7, 2021

I don't understand this PR.

@mkroening
Copy link
Member Author

We agreed on closing #270 and continue publishing libhermit on crates.io without lockfile. Since no lockfile is present for downstream builds (downloading from crates.io), we should not maintain one in this repository as well. That way we build the same way when using this repository directly (like in CI) as when building downstream.

@stlankes
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Oct 16, 2021
@bors @mkroening
Merge #276
bec934c 
276: Remove Cargo.lock r=stlankes a=mkroening

Since we use no`Cargo.lock` in downstream builds, we should not use one in upstream CI either.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2021

Build failed:

@mkroening
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Oct 17, 2021
@bors @mkroening
Merge #276
da8481b 
276: Remove Cargo.lock r=stlankes a=mkroening

Since we use no`Cargo.lock` in downstream builds, we should not use one in upstream CI either.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
@bors
Copy link
Contributor

bors bot commented Oct 17, 2021

Build failed:

@mkroening
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Oct 27, 2021
@bors @mkroening
Merge #276
edf94b8 
276: Remove Cargo.lock r=stlankes a=mkroening

Since we use no`Cargo.lock` in downstream builds, we should not use one in upstream CI either.

Co-authored-by: Martin Kröning <mkroening@posteo.net>
@bors
Copy link
Contributor

bors bot commented Oct 27, 2021

Build failed:

@mkroening
Copy link
Member Author

bors retry

@bors
Copy link
Contributor

bors bot commented Oct 29, 2021

Build succeeded:

@bors bors bot merged commit 7ff3ad0 into hermit-os:master Oct 29, 2021
@mkroening mkroening deleted the remove-cargo-lock branch October 29, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlankes stlankes Awaiting requested review from stlankes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkroening @stlankes