Skip to content

Commit

Permalink
fix(firecracker): don't try to set invalid CR3 flag
Browse files Browse the repository at this point in the history
  • Loading branch information
mkroening committed Dec 10, 2024
1 parent 1a31069 commit 32328a3
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/arch/x86_64/entry.s
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ L1:

# Set CR3
mov eax, OFFSET boot_pml4
# or eax, (1 << 0) # set present bit
mov cr3, eax

# we need to enable PAE modus
Expand Down
1 change: 0 additions & 1 deletion src/arch/x86_64/entry_fc.s
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ _start:

# Set CR3
mov rax, OFFSET boot_pml4
;or rax, (1 << 0) # set present bit
mov cr3, rax

lgdt [GDT64.Pointer] # Load the 64-bit global descriptor table.
Expand Down

0 comments on commit 32328a3

Please sign in to comment.