Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devicetree for x86_64 #287

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Create devicetree for x86_64 #287

merged 1 commit into from
Feb 16, 2024

Conversation

duanyu-yu
Copy link
Contributor

Pass memory region infomation from devicetree

@duanyu-yu duanyu-yu force-pushed the fdt branch 5 times, most recently from 3086be2 to c3c9bd1 Compare February 5, 2024 20:09
@mkroening mkroening self-requested a review February 5, 2024 20:33
@mkroening mkroening self-assigned this Feb 5, 2024
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is looking good!

I have two requests, though. :)

src/main.rs Outdated Show resolved Hide resolved
src/arch/x86_64/fdt.rs Outdated Show resolved Hide resolved
@duanyu-yu
Copy link
Contributor Author

I made some changes regarding your requests. Could clippy::new_ret_no_self be allowed?

@duanyu-yu duanyu-yu force-pushed the fdt branch 2 times, most recently from b009914 to 1ed9494 Compare February 8, 2024 23:55
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments, then this is ready to merge! :)

src/arch/x86_64/fdt.rs Outdated Show resolved Hide resolved
src/arch/x86_64/fdt.rs Outdated Show resolved Hide resolved
Pass memory region infomation from devicetree
Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mkroening mkroening added this pull request to the merge queue Feb 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2024
@mkroening mkroening added this pull request to the merge queue Feb 16, 2024
Merged via the queue into hermit-os:main with commit 7d3731e Feb 16, 2024
13 checks passed
@mkroening mkroening mentioned this pull request Apr 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants