Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbox mutexes, condvars and rwlocks on hermit #3

Merged
merged 3 commits into from
Aug 13, 2021
Merged

Unbox mutexes, condvars and rwlocks on hermit #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b70f934
Don't put hermit mutexes in a box.
mkroening Jun 13, 2021
1f3c794
Don't put hermit condvars in a box.
mkroening Jun 13, 2021
cc90e48
Don't put hermit rwlocks in a box.
mkroening Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/std/src/sys/hermit/condvar.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ pub struct Condvar {
sem2: *const c_void,
}

pub type MovableCondvar = Box<Condvar>;
pub type MovableCondvar = Condvar;

unsafe impl Send for Condvar {}
unsafe impl Sync for Condvar {}
Expand Down
2 changes: 1 addition & 1 deletion library/std/src/sys/hermit/mutex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ pub struct Mutex {
inner: Spinlock<MutexInner>,
}

pub type MovableMutex = Box<Mutex>;
pub type MovableMutex = Mutex;

unsafe impl Send for Mutex {}
unsafe impl Sync for Mutex {}
Expand Down
2 changes: 1 addition & 1 deletion library/std/src/sys/hermit/rwlock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ pub struct RWLock {
state: UnsafeCell<State>,
}

pub type MovableRWLock = Box<RWLock>;
pub type MovableRWLock = RWLock;

enum State {
Unlocked,
Expand Down