Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old uhyve interface is based on the
outb
instruction (on x86_64). This creates issues, when the physical memory of the guest is beyond the 32-Bit boundary, as theoutb
instruction only accepts 32-bit parameters.I think the best approach is to move to MMIO based hypercalls instead (as also suggested in the KVM docu). Drawback: They are slower than IO based hypercalls.
Whilst on it, I redefined the hypercall interface and added the definition for possible future hypercalls.
Summary:
GetTime
andSleep
hypercallsThis is a non-breaking change, as the old hypercall interface can still be implemented in uhhve. However, Currently, the memory where the hypercalls are mapped is mapped as regular memory. However, this will be changed in #725
The old interface can be marked deprecated and be removed in future versions.