docs(readme): change tagline, condense information #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0toose
commented
Dec 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
=======================================
Coverage 71.85% 71.85%
=======================================
Files 23 23
Lines 3063 3063
=======================================
Hits 2201 2201
Misses 862 862 ☔ View full report in Codecov by Sentry. |
jounathaen
reviewed
Dec 10, 2024
| @@ -1,11 +1,11 @@ | |||
| <img width="200" align="right" src="img/uhyve.svg" /> | |||
|
|
|||
| # Uhyve - A minimal hypervisor for Hermit | |||
There was a problem hiding this comment.
I actually like the tagline. Why should we remove it?
There was a problem hiding this comment.
My personal opinion is that it looks slightly because of the line wrap, and its content is not much different to what is said right below the header. I think this would look better (the icons were put under the tagline, this PR doesn't have that).
Nevertheless, it's a matter of preference and not a hill to die on.
jounathaen
force-pushed
the
readme-change-tagline
branch
from
3f534cb to
31db2e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'cause why not