Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): fix configuration section #838

Merged
merged 1 commit into from
Dec 13, 2024
Merged

docs(readme): fix configuration section #838

merged 1 commit into from
Dec 13, 2024

Conversation

mkroening
Copy link
Member

Closes #837.

This was introduced in 0384c1d.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.85%. Comparing base (16315dc) to head (551e5ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #838   +/-   ##
=======================================
  Coverage   71.85%   71.85%           
=======================================
  Files          23       23           
  Lines        3063     3063           
=======================================
  Hits         2201     2201           
  Misses        862      862           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@n0toose n0toose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hesitantly using the Code Review functionality to express that I find this change to be a considerable improvement that fixes the underlying issue. :)

@jounathaen jounathaen added this pull request to the merge queue Dec 13, 2024
@jounathaen
Copy link
Member

👍

Merged via the queue into main with commit a8ef91e Dec 13, 2024
11 checks passed
@jounathaen jounathaen deleted the readme-config branch December 13, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme section on usage is outdated
3 participants