Log a warning instead of throwing an exception when opt is not availa… #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble in the system Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
ThomasHaas
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Does this even work because you still return the path to the opt file (which was not generated)? Shouldn't you return the original file instead?
Also, I would make it more clear that we continue without optimizations. Something like this:
Failed to run opt (llvm optimizations). Continuing without optimizations.
Good catch. I tested it, but in my case it was working because I have the |
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
tonghaining
pushed a commit
to tonghaining/Dat3M
that referenced
this pull request
May 24, 2024
hernanponcedeleon#666) Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com> Co-authored-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ble in the system