-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check all three properties by default #675
Conversation
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
EDIT: As you probably noticed, some unit tests used the default properties and now they fail. This also shows a problem in regards to litmus code assertions: it is not guaranteed that you can even check all three properties at the same time!
Only for C-code you know that all properties are of the same type.
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
You are right, but we don't have any real user checking litmus tests. I still think we should use all 3 properties as default and maybe just improve the error msg (i.e., tell the user what to do) when mixed type properties are used
->
|
Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
Fine with me |
…ernanponcedeleon#675) * Check all three properties by default * Force thread creation to succeed by default * Improve error msg for mixed type properties --------- Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com> Co-authored-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
No description provided.