Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for subscription validation APIs that were added in Nakama v3.13.0 (Godot 4) #126

Merged

Conversation

dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Sep 25, 2022

No description provided.

Copy link
Contributor

@lugehorsam lugehorsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT of gradually adding a test suite to this client @dsnopek ? Also what are your thoughts on C# adoption in Godot currently and what it could be moving forward to Godot 4?

@dsnopek
Copy link
Contributor Author

dsnopek commented Sep 26, 2022

WDYT of gradually adding a test suite to this client

There is a test suite, and it does pass for both Godot 3 & 4, but it isn't super complete. We could certainly expand it to cover more of the API!

Also what are your thoughts on C# adoption in Godot currently and what it could be moving forward to Godot 4?

That's a good question! With C#, folks should use the normal Nakama .NET client, but we do include some extra integration classes in this addon, mainly to allow the HTML5 export to work. I haven't ported those over to Godot 4 yet - the big update to .NET 6 was just merged a month ago (and many bug fixes since), so it would be a good time now to look into doing that.

How about we open new issues for those two things?

@lugehorsam
Copy link
Contributor

NP @dsnopek subscriptions are hard to write integration tests for at the moment anyway. I don't think we have any in our SDKs.

@dsnopek
Copy link
Contributor Author

dsnopek commented Sep 27, 2022

@dsnopek dsnopek merged commit cd9a2ce into heroiclabs:godot-4 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants