Change directory rather than setting working dir #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runesoerensen
force-pushed
the
prefer-cd-over-working-dir
branch
from
a7f1448 to
540838a
Compare
edmorley
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way launch process set the current/working directory. In particular, the current directory is changed in the command itself rather than using the
launch.tomlworking-dirsetting.The launch process detection feature is intended to both add convenience, and help users write their own
Procfilecommands when needed. However, users currently don't have any way to configure theworking-dirusing aProcfile(and have tocdinto the directory in the command). The changes in this PR aims to reduce this gap, and make it a bit easier for users to adapt launch process commands to their ownProcfilewhen needed.