Refactor HandleResult type aliases #152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runesoerensen
changed the title
runesoerensen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows how the nearly identical
HandleResulttype aliases used in the SDK and NuGet layers can be removed (either by using a shared alias for aLayerLogResult, or aliases forBuildpackLayerRefandBuildLog) defined in the layers module.The
HandleResulttype aliases were introduced during the switch tobullet_stream, which added significant complexity to some function signatures that needed to pass the output/log back and forth (causing clippy to balk).Defining one or more generic type aliases reduces some duplication, and potentially increases readability (compared to disabling that lint). Curious to hear thoughts on how we can/should approach this?