Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for npm permission error #830

Merged
merged 5 commits into from
May 23, 2024
Merged

Fix for npm permission error #830

merged 5 commits into from
May 23, 2024

Conversation

colincasey
Copy link
Contributor

@colincasey colincasey commented May 3, 2024

Registers a launch time layer that sets the following environment variables:

Closes #800

@colincasey colincasey self-assigned this May 3, 2024
@colincasey colincasey requested review from joshwlewis and a team as code owners May 3, 2024 20:53
Registers an exec.d program that:

- configures the npm `cache` to write to a temporary directory
- disables the npm `update-notifier`
@colincasey colincasey requested review from edmorley and joshwlewis May 10, 2024 19:52
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The env var approach looks good to me :-)

Leaving the main review to Josh.

buildpacks/nodejs-npm-install/src/main.rs Show resolved Hide resolved
* main:
  Prepare release v3.2.2 (#848)
  Update Inventory for heroku/nodejs (#846)
  Fix failing integration test (#847)
  Update Node functions runtime to 0.14.5 (#845)
  Update Inventory for heroku/nodejs-npm-engine (#842)
  Update Inventory for heroku/nodejs (#844)
  Fix Node.js inventory automation (#843)
  Adding Heroku-24 to CI test matrix (#841)
  Node.js inventory updates with Keep a Changelog format (#840)
  Fixed the changelog to follow the Keep a Changelog spec properly (#839)

# Conflicts:
#	buildpacks/nodejs-npm-install/CHANGELOG.md
#	buildpacks/nodejs-npm-install/tests/integration_test.rs
@colincasey colincasey merged commit 7f67b1e into main May 23, 2024
41 checks passed
@colincasey colincasey deleted the fix_issue_800 branch May 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants