Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest pip #791

Closed
wants to merge 1 commit into from
Closed

Conversation

josephlbarnett
Copy link

Also allow GIT_OAUTH_KEY environment variable to be passed through to pip.


We wanted to be able to remove github oauth key values from our requirements.txt files that are checked into source control. With later versions of pip (10+), it can read them from an environment variables. This PR updates to the current latest pip (18.1), fixing #740, and allows passthrough of a GIT_OAUTH_KEY env variable from heroku in order to meet this use case.

Allow GIT_OAUTH_KEY environment variable to be passed through to pip.
@CaseyFaist
Copy link
Contributor

Hi @josephlbarnett ! Thanks for the PR. I have some context and questions for you:

  • Currently, pip version 9 is set for both pip install and pipenv install flows. The Pipenv version currently locked in the buildpack does not work with modern pip (this was surfaced in a buildpack bug back in October). Updating Pip is necessary, but this update as-is would require significant communication with current pipenv users to avoid breaking changes.

  • Continuing to add sourced env vars is not the ideal pattern moving forward for the buildpack, although it has been necessary for blocking issues. Did you explore the private auth flow discussed in [Feature reqeust] Let python buildpack can access private repo with custom environment variables #776 ? What worked for you and what didn't?

@josephlbarnett
Copy link
Author

Thanks for the reply Casey, we hadn't looked at #776, will do so now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants