Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry Feature #807

Closed
wants to merge 70 commits into from
Closed

Poetry Feature #807

wants to merge 70 commits into from

Conversation

AndreGuerra123
Copy link

Hi,
This is a pull request for Poetry suporte. All tests passed. I simply cannot squash the commits I had done during testing. Hope some git guru could find a way to do it.
Best regards,
Andre
PS: Change.log and Docs should be updated after this since I have not run it throw the CI yet.

@@ -15,8 +15,8 @@
BUILD_DIR=$1

# Exit early if app is clearly not Python.
if [ ! -f "$BUILD_DIR/requirements.txt" ] && [ ! -f "$BUILD_DIR/setup.py" ] && [ ! -f "$BUILD_DIR/Pipfile" ]; then
if [ -f "$BUILD_DIR/requirements.txt" ] || [ -f "$BUILD_DIR/setup.py" ] || [ -f "$BUILD_DIR/Pipfile" ] || [ -f "$BUILD_DIR/Pipfile.lock"] || [ -f "$BUILD_DIR/pyproject.py"] || [ -f "$BUILD_DIR/poetry.lock"]; then
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: pyproject.py → pyproject.toml

@golyalpha
Copy link

Hey @AndreGuerra123, finally got around to testing your build pack up on heroku. Turns out it doesn't really work, this is the output of a poetry init'd application:

remote: Building source:
remote:
remote: -----> App not compatible with buildpack: https://github.com/AndreGuerra123/heroku-buildpack-python
remote:        /app/tmp/buildpacks/ec54514b94a989eed25f4d661d388c2a76ff9a77f682be84c1fde83956d360e594184baaf59d6fa4dc9e0641f0c3a2aae68a52f83c2c3863ab7abfcd91638b7c/bin/detect: line 18: [: missing `]'
remote: /app/tmp/buildpacks/ec54514b94a989eed25f4d661d388c2a76ff9a77f682be84c1fde83956d360e594184baaf59d6fa4dc9e0641f0c3a2aae68a52f83c2c3863ab7abfcd91638b7c/bin/detect: line 18: [: missing `]'
remote: /app/tmp/buildpacks/ec54514b94a989eed25f4d661d388c2a76ff9a77f682be84c1fde83956d360e594184baaf59d6fa4dc9e0641f0c3a2aae68a52f83c2c3863ab7abfcd91638b7c/bin/detect: line 18: [: missing `]'

I'll go through your code, check what's going on and drop a review so you can fix it.

@CaseyFaist
Copy link
Contributor

Hi @AndreGuerra123 !

Thanks for the pr! ❤️ 🌮 ❤️ I appreciate the time you've spent here. There have been several different poetry support prs, and after reviewing them all, #835's implementation is the one I'll be moving forward with.

The good news is that this functionality should be coming soon 👍thank you for your contributions!

@CaseyFaist CaseyFaist closed this Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants