Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad binstub shebang lines #990

Closed
schneems opened this issue May 7, 2020 · 0 comments
Closed

Bad binstub shebang lines #990

schneems opened this issue May 7, 2020 · 0 comments

Comments

@schneems
Copy link
Contributor

schneems commented May 7, 2020

There is a class of errors caused by when a binstub has a bad shebang line. For instance:

#!/usr/bin/env ruby2.5

Instead of

#!/usr/bin/env ruby

This was previously attempted to be mitigated in:

This came up recently in:
https://heroku.support/858951

However overall support volume for this class of errors is relatively low.

We could revisit adding a warning. We could also possibly alias the most common ruby versions such as ruby2.5 => ruby etc. but this might have undesired side effects. It's unknown if anyone is attempting to "dual boot" multiple versions of Rubies. I've not seen anything like that yet, but it doesn't mean it doesn't exist.

schneems added a commit that referenced this issue Jun 11, 2020
krisrang referenced this issue in skyltmax/heroku-buildpack-ruby Oct 2, 2020
* upstream/master:
  [changelog skip] Bring back rake task (#1038)
  CNB: make the gems layer accessible to subsequent buildpacks #1033  (#1037)
  [close #934] Skip rake task if it does not exist (#1036)
  [changelog skip] Move unreleased changelogs (#1035)
  v218 for Monday release (#1034)
  [close #1029] Remove default bin/rake binstub (#1031)
  Document v217 release in master (#1030)
  [close #1027][changelog skip] Fix frozen string error (#1028)
  Handle binary binstubs (#1021)
  v216 release for monday (#1023)
  Revert "Merge pull request #1014 from heroku/schneems/fu-binstubs"
  [close #990] Warn on bad shebang line
  [close #818] Disable spring
  [changelog skip][close #977] Recommend recent Ruby in warning
  [changelog skip][close #977] Recommend recent Ruby in warning
  [close #1001] Put Yarn first on the path
  Update HEREDOC to 2.5 syntax to support indenting
  Switch to using /usr/bin/env bash
  [changelog skip] Fix CNB tests
  Allow Nolockfile to get to compile phase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant