Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js default to 22.11.0 #1503

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Update Node.js default to 22.11.0 #1503

merged 5 commits into from
Nov 8, 2024

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Oct 31, 2024

Node.js 22.x is now the Active LTS release line as of 10-29-2024 (source). In accordance with Heroku's Node.js support policy, it should be the default version.

The same change for Node.js 20: #1397

@joshwlewis joshwlewis requested review from schneems and a team as code owners October 31, 2024 18:06
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
@schneems
Copy link
Contributor

schneems commented Nov 1, 2024

I've got some un-released changes on main. I'm going to roll this into those changes and aim for November 9th.

Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming tests pass:

$ be rspec "./spec/helpers/node_installer_spec.rb[1:1:2]"
Run options: include {:focused=>true, :ids=>{"./spec/helpers/node_installer_spec.rb"=>["1:1:2"]}}
.

Finished in 2.81 seconds (files took 0.28492 seconds to load)
1 example, 0 failures

⛄️ 3.1.6 🚀 /Users/rschneeman/Documents/projects/work/heroku-buildpack-ruby (jwl/update-nodejs-default)
$ git log
commit 31b1cb92fcab4504c82194aaf35bd607589355cc (HEAD -> jwl/update-nodejs-default, origin/jwl/update-nodejs-default)

Copy link
Contributor

@schneems schneems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, could you add an entry in changelogs/unreleased

Similar to:

## Ruby apps now default to Node version 20.9.0

Applications using the `heroku/ruby` buildpack that do not already have `node` installed by another buildpack (such as the `heroku/nodejs`
buildpack) will now receive:

- Node.js version 20.9.0 (was previously 16.18.1)

These versions and instructions on how to specify a specific version of these binaries can be found on the [installed binaries section of the Heroku Ruby Support page](https://devcenter.heroku.com/articles/ruby-support#installed-binaries).

schneems added a commit that referenced this pull request Nov 8, 2024
@schneems schneems merged commit 8d656c6 into main Nov 8, 2024
4 checks passed
@schneems schneems deleted the jwl/update-nodejs-default branch November 8, 2024 18:03
@heroku-linguist heroku-linguist bot mentioned this pull request Nov 8, 2024
schneems added a commit that referenced this pull request Nov 11, 2024
There's an issue with the way that yarn is packaged that caused #1516 due to behavior introduced in #1503. This commit reverts to the old node/yarn versions until we can fix the underlying bug.
schneems added a commit that referenced this pull request Nov 11, 2024
There's an issue with the way that yarn is packaged that caused #1516 due to behavior introduced in #1503. This commit reverts to the old node/yarn versions until we can fix the underlying bug.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants