-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Node.js default to 22.11.0 #1503
Conversation
Co-authored-by: Ed Morley <501702+edmorley@users.noreply.github.com>
I've got some un-released changes on main. I'm going to roll this into those changes and aim for November 9th. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming tests pass:
$ be rspec "./spec/helpers/node_installer_spec.rb[1:1:2]"
Run options: include {:focused=>true, :ids=>{"./spec/helpers/node_installer_spec.rb"=>["1:1:2"]}}
.
Finished in 2.81 seconds (files took 0.28492 seconds to load)
1 example, 0 failures
⛄️ 3.1.6 🚀 /Users/rschneeman/Documents/projects/work/heroku-buildpack-ruby (jwl/update-nodejs-default)
$ git log
commit 31b1cb92fcab4504c82194aaf35bd607589355cc (HEAD -> jwl/update-nodejs-default, origin/jwl/update-nodejs-default)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, could you add an entry in changelogs/unreleased
Similar to:
## Ruby apps now default to Node version 20.9.0
Applications using the `heroku/ruby` buildpack that do not already have `node` installed by another buildpack (such as the `heroku/nodejs`
buildpack) will now receive:
- Node.js version 20.9.0 (was previously 16.18.1)
These versions and instructions on how to specify a specific version of these binaries can be found on the [installed binaries section of the Heroku Ruby Support page](https://devcenter.heroku.com/articles/ruby-support#installed-binaries).
Node.js 22.x is now the Active LTS release line as of 10-29-2024 (source). In accordance with Heroku's Node.js support policy, it should be the default version.
The same change for Node.js 20: #1397