-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make bundle clean
have the same context as bundle install
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
hone
added a commit
that referenced
this pull request
Feb 25, 2015
Make `bundle clean` have the same context as `bundle install`
outoftime
pushed a commit
to Genius/heroku-buildpack-ruby
that referenced
this pull request
Mar 10, 2015
into upstream_update * 'master' of https://github.com/heroku/heroku-buildpack-ruby: (51 commits) bump to v134 v134 changelog Use more generic flag for sensible default detect Enable Rails 5 to work on Heroku changelog for heroku/heroku-buildpack-ruby#347 Allow opting in to default WEB_CONCURRENCY pass user env to bundle clean, since it should run in the same env as bundle install use same bundler bin for every bundler command control all of our test repos don't vendor in JVM on cedar-14 as it's now available on the stack. changelog for 133 bump to v133 bundler 1.7 Fail fast if ENV["STACK"] is missing bump to v132 update changelog [ci skip] special case for patchlevel rubies. fixes jruby 9.0.0.0.pre1 Set PX ram limits to correct value: https://devcenter.heroku.com/articles/dyno-size#available-dyno-sizes wait on autoscaling Scale back JRuby heap size on PX dynos to give room for native memory allocation ...
cbartlett
added a commit
to cbartlett/heroku-buildpack-ruby-tpope
that referenced
this pull request
Mar 18, 2015
* heroku/master: (42 commits) bump to v134 v134 changelog Use more generic flag for sensible default detect Enable Rails 5 to work on Heroku changelog for heroku/heroku-buildpack-ruby#347 Allow opting in to default WEB_CONCURRENCY pass user env to bundle clean, since it should run in the same env as bundle install use same bundler bin for every bundler command control all of our test repos don't vendor in JVM on cedar-14 as it's now available on the stack. changelog for 133 bump to v133 bundler 1.7 Fail fast if ENV["STACK"] is missing bump to v132 update changelog [ci skip] special case for patchlevel rubies. fixes jruby 9.0.0.0.pre1 Set PX ram limits to correct value: https://devcenter.heroku.com/articles/dyno-size#available-dyno-sizes wait on autoscaling Scale back JRuby heap size on PX dynos to give room for native memory allocation ...
aemengo
pushed a commit
to cloudfoundry/ruby-buildpack
that referenced
this pull request
Mar 31, 2015
sibsfinx
pushed a commit
to sibsfinx/heroku-buildpack-ruby
that referenced
this pull request
Apr 14, 2015
lcfg
pushed a commit
to lcfg/heroku-buildpack-jekyll
that referenced
this pull request
Jun 22, 2015
lyoshenka
added a commit
to lyoshenka/heroku-buildpack-ruby-jekyll
that referenced
this pull request
Aug 3, 2015
https://github.com/codykrieger/heroku-buildpack-jekyll * cody/master: (239 commits) bump to v134 v134 changelog Use more generic flag for sensible default detect Enable Rails 5 to work on Heroku changelog for heroku/heroku-buildpack-ruby#347 Allow opting in to default WEB_CONCURRENCY pass user env to bundle clean, since it should run in the same env as bundle install use same bundler bin for every bundler command control all of our test repos don't vendor in JVM on cedar-14 as it's now available on the stack. changelog for 133 bump to v133 bundler 1.7 Fail fast if ENV["STACK"] is missing bump to v132 update changelog [ci skip] special case for patchlevel rubies. fixes jruby 9.0.0.0.pre1 Set PX ram limits to correct value: https://devcenter.heroku.com/articles/dyno-size#available-dyno-sizes wait on autoscaling Scale back JRuby heap size on PX dynos to give room for native memory allocation ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has a crazy Gemfile where it executes code based on the environment,
bundle clean
might fail whilebundle install
works because the context is different. Let's pass the user env tobundle clean
as well.