Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make httpmetris work better with OTEL #198

Merged
merged 7 commits into from
Jul 19, 2023
Merged

Make httpmetris work better with OTEL #198

merged 7 commits into from
Jul 19, 2023

Conversation

ypaq
Copy link
Contributor

@ypaq ypaq commented Jul 18, 2023 •
edited
Loading

Rationale

Here we add a option to improve HTTP metrics reporting with OTEL.

Changes

  • Add NewOTEL function to httpmetrics which uses attributes over metric names

Meta

W-13781478

voidlock
voidlock requested changes Jul 19, 2023
View reviewed changes
Copy link
Member

@voidlock voidlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Once this gets merged, I plan on removing the custom go-logplex version and migrate to on this one.

I left a comment regarding the new http.server.active_requests metric though.

hmiddleware/httpmetrics/httpmetrics_v2.go Outdated Show resolved Hide resolved
hmiddleware/httpmetrics/httpmetrics_v2.go Outdated Show resolved Hide resolved
@ypaq ypaq requested a review from voidlock July 19, 2023 19:16
@ypaq ypaq merged commit 8431ac4 into master Jul 19, 2023
2 checks passed
@ypaq ypaq deleted the improve-httpmetrics branch July 19, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voidlock voidlock voidlock approved these changes

@mandeepbal mandeepbal mandeepbal approved these changes

@agnaite agnaite Awaiting requested review from agnaite

@cgfuh cgfuh Awaiting requested review from cgfuh

@slizco slizco Awaiting requested review from slizco

@Vamsi-Mundra Vamsi-Mundra Awaiting requested review from Vamsi-Mundra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ypaq @voidlock @mandeepbal